refactor: remove redundant pylint disable from celery instrumentation #3839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the redundant
pylint: disable=attribute-defined-outside-init
comment from the celery instrumentation and adds this rule to the global pylint disable list in.pylintrc
.The
attribute-defined-outside-init
pylint rule is problematic for OpenTelemetry instrumentations because attributes are commonly set during instrumentation (in methods like_instrument()
) rather than in__init__
. This pattern is used throughout the codebase (30+ occurrences) and is a standard practice for OpenTelemetry instrumentations where attributes are initialized during the instrumentation process.By disabling this rule globally, we eliminate the need for individual
pylint: disable
comments across the codebase, making the code cleaner and more maintainable.Fixes #3828
Type of change
How Has This Been Tested?
attribute-defined-outside-init
has been added to the global pylint disable listDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.